logging: Move trace class definitions to uapi/logging.h#462
Merged
lgirdwood merged 1 commit intothesofproject:masterfrom Oct 5, 2018
Merged
logging: Move trace class definitions to uapi/logging.h#462lgirdwood merged 1 commit intothesofproject:masterfrom
lgirdwood merged 1 commit intothesofproject:masterfrom
Conversation
Move definitions into header that would be shared between SOF and SOFT. Paste SOF_ABI_VERSION into FW ready message. Also remove unused code from uapi/logging.h. Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
lgirdwood
reviewed
Oct 4, 2018
|
|
||
| #define LOG_LEVEL_CRITICAL 1 /* (FDK fatal) */ | ||
| #define LOG_LEVEL_HIGH 2 /* (FDK error) */ | ||
| #define LOG_LEVEL_MEDIUM 3 /* (FDK warning) */ |
Member
There was a problem hiding this comment.
Why would we remove the log level ? I cant see where it's re-added ?
Member
Author
There was a problem hiding this comment.
@lgirdwood We don't use any of the mid-level logs. Either it's critical = error, or verbose = plain trace.
After short discussion with @mmaka1 we decided to remove all unused in-between log levels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move definitions into header that would be shared between SOF and SOFT.
Paste SOF_ABI_VERSION into FW ready message.
Also remove unused code from uapi/logging.h.
Signed-off-by: ArturX Kloniecki arturx.kloniecki@linux.intel.com